deniskuzZ commented on code in PR #5652:
URL: https://github.com/apache/hive/pull/5652#discussion_r2014629029
##########
common/src/java/org/apache/hive/http/HttpServer.java:
##########
@@ -808,14 +876,23 @@ public void addServlet(String name, String pathSpec,
if (name != null) {
holder.setName(name);
}
+ webAppContexts.get(0).addServlet(holder, pathSpec);
+ }
+
+ private void addServlet(String name, String pathSpec, Class<? extends
HttpServlet> clazz,
+ WebAppContext webAppContext) {
+ ServletHolder holder = new ServletHolder(clazz);
+ if (name != null) {
+ holder.setName(name);
+ }
webAppContext.addServlet(holder, pathSpec);
}
public void addServlet(String name, String pathSpec, ServletHolder holder) {
if (name != null) {
holder.setName(name);
}
- webAppContext.addServlet(holder, pathSpec);
+ webAppContexts.get(0).addServlet(holder, pathSpec);
Review Comment:
same - 'reuse'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
