difin commented on code in PR #5652: URL: https://github.com/apache/hive/pull/5652#discussion_r2015067251
########## service/src/java/org/apache/hive/service/servlet/HS2HAHealthChecker.java: ########## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hive.service.servlet; + +import javax.servlet.http.HttpServletRequest; +import javax.servlet.http.HttpServletResponse; +import java.io.IOException; + +public class HS2HAHealthChecker extends HS2LeadershipStatus { + + @Override + public void doDelete(final HttpServletRequest request, final HttpServletResponse response) throws IOException { Review Comment: HS2LeadershipStatus has 2 functions: 1. Leader status (GET route) 2. Failover initiation (DELETE route) Health check endpoint is supposed to allow only getting the leadership status. This is what is used for health checking. The new health check endpoint is going to be not secured by LDAP and it meant for health checking only. This is needed to disable the ability to initiate failover via health check route. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
