deniskuzZ commented on code in PR #5649:
URL: https://github.com/apache/hive/pull/5649#discussion_r2017455156
##########
ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java:
##########
@@ -341,6 +345,29 @@ public enum AuthorizationMode{V1, V2};
*/
private boolean compaction = false;
+ // A thread-safe set to hold all active session states
+ private static final Set<SessionState> sessionStates =
Collections.newSetFromMap(new ConcurrentHashMap<>());
+
+ // Thread pool for concurrent cleanup
+ private static final ExecutorService cleanupExecutor =
Executors.newCachedThreadPool();
+
+ // Static block to add a single shutdown hook for all session states
+ static {
+ ShutdownHookManager.addShutdownHook(new Thread(() -> {
Review Comment:
can't we pass Runnable? why are you creating a new Thread?
````
ShutdownHookManager.addShutdownHook(SessionState::cleanUpAllSessions);
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
