kasakrisz commented on code in PR #5649:
URL: https://github.com/apache/hive/pull/5649#discussion_r2022232807
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMaterializedViewsRegistry.java:
##########
@@ -167,12 +168,10 @@ private Loader(Hive db) {
@Override
public void run() {
- SessionState ss = new SessionState(db.getConf());
- ss.setIsHiveServerQuery(true); // All is served from HS2, we do not need
e.g. Tez sessions
- SessionState.start(ss);
PerfLogger perfLogger = SessionState.getPerfLogger();
- perfLogger.perfLogBegin(CLASS_NAME,
PerfLogger.MATERIALIZED_VIEWS_REGISTRY_REFRESH);
try {
+ DriverUtils.setUpSessionState(db.getConf());
Review Comment:
nit: This refactor doesn't change the existing behavior. However the method
`setUpSessionState` hides that we not just setup the SessionState but also
start it. IMHO the original code emphasised this better.
A method name like `setUpAndStartSessionState` would also be better.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
