deniskuzZ commented on code in PR #5674:
URL: https://github.com/apache/hive/pull/5674#discussion_r2023064382
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/columnstats/aggr/LongColumnStatsAggregator.java:
##########
@@ -242,6 +242,24 @@ public ColumnStatisticsObj
aggregate(List<ColStatsObjWithSourceInfo> colStatsWit
}
statsObj.setStatsData(columnStatisticsData);
+
+ // NDV cannot exceed the number of integers within the given range.
Review Comment:
ok, but isn't correction applied at the very end after `extrapolate ` now?
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/columnstats/aggr/LongColumnStatsAggregator.java:
##########
@@ -242,6 +242,24 @@ public ColumnStatisticsObj
aggregate(List<ColStatsObjWithSourceInfo> colStatsWit
}
statsObj.setStatsData(columnStatisticsData);
+
+ // NDV cannot exceed the number of integers within the given range.
Review Comment:
ok, but isn't correction applied at the end after `extrapolate ` now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
