deniskuzZ commented on code in PR #5722:
URL: https://github.com/apache/hive/pull/5722#discussion_r2027207789
##########
iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStatistics.java:
##########
@@ -52,14 +53,20 @@ public class TestHiveIcebergStatistics extends
HiveIcebergStorageHandlerWithEngi
@Parameterized.Parameter(4)
public String statsSource;
- @Parameterized.Parameters(name = "fileFormat={0}, catalog={1},
isVectorized={2}, formatVersion={3}, statsSource={4}")
+ @Parameterized.Parameter(5)
+ public boolean isLockEnabled;
+
+ @Parameterized.Parameters(name = "fileFormat={0}, catalog={1},
isVectorized={2}, " +
+ "formatVersion={3}, statsSource={4}, isLockEnabled={5}")
public static Collection<Object[]> parameters() {
Collection<Object[]> baseParams =
HiveIcebergStorageHandlerWithEngineBase.parameters();
Collection<Object[]> testParams = Lists.newArrayList();
for (String statsSource : new String[]{"iceberg", "metastore"}) {
- for (Object[] params : baseParams) {
- testParams.add(ArrayUtils.add(params, statsSource));
+ for (boolean isLockEnabled : new boolean[]{true, false}) {
Review Comment:
That would cause all other tests to run twice. Maybe better to create 2
tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
