deniskuzZ commented on code in PR #5652:
URL: https://github.com/apache/hive/pull/5652#discussion_r2014561694
##########
common/src/java/org/apache/hive/http/HttpServer.java:
##########
@@ -534,9 +542,110 @@ private void setupCORSFilter(Builder b) {
}
/**
- * Create a channel connector for "http/https" requests
+ * Creates a port connector and initializes a web application that processes
requests through the newly
+ * created port connector.
+ *
+ * @param builder - The builder object used to configure and create the port
connector and web application.
+ * @return ContextHandlerCollection - A collection of request handlers
associated with the new port connector,
+ * which includes the newly initialized web application.
+ */
+ public ContextHandlerCollection addWebApp(Builder builder) throws
IOException {
+ WebAppContext webAppContext = createWebAppContext(builder);
+ initWebAppContext(builder, webAppContext);
+ RewriteHandler rwHandler = createRewriteHandler(builder, webAppContext);
+
+ ContextHandlerCollection portHandler = new ContextHandlerCollection();
+ ServerConnector connector = addChannelConnector(threadPool.getQueueSize(),
builder);
Review Comment:
should we move `connector` closer to it's actual use?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
