owenmonn commented on code in PR #5722:
URL: https://github.com/apache/hive/pull/5722#discussion_r2026810696
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java:
##########
@@ -422,6 +426,32 @@ public void
preAlterTable(org.apache.hadoop.hive.metastore.api.Table hmsTable, E
}
}
+ private HiveLock lockObject(org.apache.hadoop.hive.metastore.api.Table
hmsTable) {
+ if (hiveLockEnabled(hmsTable, conf)) {
+ return new MetastoreLock(conf, new CachedClientPool(conf,
Maps.fromProperties(catalogProperties)),
+ catalogProperties.getProperty(Catalogs.NAME), hmsTable.getDbName(),
hmsTable.getTableName());
+ } else {
+ return new NoLock();
+ }
+ }
+
+ private static boolean
hiveLockEnabled(org.apache.hadoop.hive.metastore.api.Table hmsTable,
Configuration conf) {
+ if (SessionStateUtil.getQueryState(conf).map(QueryState::getHiveOperation)
Review Comment:
After the additional
[commit](https://github.com/apache/hive/pull/5722/commits/b663804786cb616ace3aafbc0955c7e702109f8d),
If the situation you're concerned about still exists, could you please
inform me about it via a script?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
