mszurap commented on PR #5701: URL: https://github.com/apache/hive/pull/5701#issuecomment-2752013188
Hi @Aggarwal-Raghav , thanks for looking at this. Not as an excuse, but even now, if there is a space anywhere in the ";sess_var_list?hive_conf_list#hive_var_list" part, the string.split will split it and this usecase breaks even now, anybody wanting that already needs to escape the spaces. If we want to support spaces in the ";sess_var_list?hive_conf_list#hive_var_list" part too, then: 1. we either need to refactor the whole code to avoid the string splitting by space and pass the parameters in a different way to the "Commands" (haven't explored how complex is this) 2. or we use the same approach but carefully, we can skip removing the spaces after the semicolon, the question mark or the hashtag sign. Would you agree to this rather? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
