soumyakanti3578 commented on code in PR #5720:
URL: https://github.com/apache/hive/pull/5720#discussion_r2019471740


##########
packaging/src/license/licenses.xml:
##########
@@ -31,6 +31,29 @@
         </license>
       </licenses>
     </dependency>
+    <dependency>
+      <groupId>org.apache.tomcat</groupId>
+      <artifactId>tomcat-servlet-api</artifactId>
+      <version>9.0.82</version>

Review Comment:
   It's better to create a variable for versions so that we can reuse them 
elsewhere. You can probably add 
   ```
   <tomcat.version>9.0.82</tomcat.version>
   ```
   in the root pom's properties.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to