difin commented on code in PR #5729:
URL: https://github.com/apache/hive/pull/5729#discussion_r2034038134


##########
common/src/test/org/apache/hive/common/IPStackUtilsTest.java:
##########
@@ -164,20 +142,68 @@ void 
testWildcardWhenIPv6IsNotPreferredAndIPv6WildcardProvided() {
   }
 
   @Test
-  void testWildcardWhenNonWildcardIPv4AddressProvided() {
-    String result = IPStackUtils.adaptWildcardAddress("192.168.1.1");
-    assertEquals("192.168.1.1", result);
+  void testAdaptWildcardAddress() {
+    assertEquals("192.168.1.1", 
IPStackUtils.adaptWildcardAddress("192.168.1.1"));
+    assertEquals("2001:db8::1", 
IPStackUtils.adaptWildcardAddress("2001:db8::1"));
+    assertEquals("example.com", 
IPStackUtils.adaptWildcardAddress("example.com"));
+  }
+
+    // Test cases for splitHostPort method

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to