mdayakar commented on code in PR #5746:
URL: https://github.com/apache/hive/pull/5746#discussion_r2035178576


##########
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java:
##########
@@ -4180,6 +4180,7 @@ private RelNode genSelectForWindowing(QB qb, RelNode 
srcRel, HashSet<ColumnInfo>
 
       // 3. Construct new Row Resolver with everything from below.
       RowResolver out_rwsch = new RowResolver();
+      out_rwsch.setExprResolver(inputRR.getIsExprResolver());

Review Comment:
   ok got your point, in the current flow `inputRR` related to group by for 
which `isExprResolver` is always true as per code flow so I feel the code 
changes are fine.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to