ayushtkn commented on code in PR #5758: URL: https://github.com/apache/hive/pull/5758#discussion_r2042847946
########## standalone-metastore/metastore-common/pom.xml: ########## @@ -333,6 +333,12 @@ <artifactId>slf4j-simple</artifactId> <scope>test</scope> </dependency> + <dependency> + <groupId>org.junit.jupiter</groupId> + <artifactId>junit-jupiter-engine</artifactId> + <version>${junit.jupiter.version}</version> + <scope>test</scope> + </dependency> Review Comment: Why is this kicking in here? the junit depedency in past have led to tests being silently ignored, can you check if the total number of tests that ran didn't reduce. I suspect they did -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org