zratkai commented on code in PR #5628:
URL: https://github.com/apache/hive/pull/5628#discussion_r2043976959
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java:
##########
@@ -5839,13 +5840,30 @@ public HiveMetaHook getHook(
}
};
+ if ("rest".equals(conf.get("metastore.type", "hms"))) {
+ return getHiveIcebergRESTCatalog(conf);
+ }
+
if (conf.getBoolVar(ConfVars.METASTORE_FASTPATH)) {
return new SessionHiveMetaStoreClient(conf, hookLoader, allowEmbedded);
} else {
return RetryingMetaStoreClient.getProxy(conf, hookLoader,
metaCallTimeMap,
SessionHiveMetaStoreClient.class.getName(), allowEmbedded);
}
}
+ private IMetaStoreClient getHiveIcebergRESTCatalog(HiveConf conf) throws
MetaException {
+ try {
+ Class<? extends IMetaStoreClient> handlerClass =
+ (Class<? extends IMetaStoreClient>)
+
Class.forName("org.apache.iceberg.hive.HiveIcebergRESTCatalogClientAdapter",
true, Utilities.getSessionSpecifiedClassLoader());
+ IMetaStoreClient restCatalogMetastoreClient =
ReflectionUtils.newInstance(handlerClass, conf);
+ restCatalogMetastoreClient.reconnect();
+ return restCatalogMetastoreClient;
Review Comment:
Thank you all for bringing this topic! I think we should handle this once
those tickets got merged. I am happy to refactor this after.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
