saihemanth-cloudera commented on code in PR #5766:
URL: https://github.com/apache/hive/pull/5766#discussion_r2044812076


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java:
##########
@@ -6051,8 +6051,9 @@ private void alter_partition_core(String catName, String 
db_name, String tbl_nam
     Exception ex = null;
     try {
       Table table = getMS().getTable(catName, db_name, tbl_name, null);
+      Partition oldPartition = getMS().getPartition(catName, db_name, 
tbl_name, part_vals);

Review Comment:
   nit: we fetch oldPart at L6062, can you see if you can eliminate this 
redundant call?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to