okumin commented on code in PR #5776: URL: https://github.com/apache/hive/pull/5776#discussion_r2052351667
########## shims/common/src/main/java/org/apache/hadoop/util/SuppressFBWarnings.java: ########## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.util; + +import java.lang.annotation.Retention; +import java.lang.annotation.RetentionPolicy; + +@Retention(RetentionPolicy.CLASS) +public @interface SuppressFBWarnings { Review Comment: Can we remove a copy from shims/0.23? https://github.com/apache/hive/blob/master/shims/0.23/src/main/java/org/apache/hadoop/util/SuppressFBWarnings.java I assume shims/0.23 inherits shims/common here. If my assumption is wrong, we can keep duplicates at this point. ########## shims/0.23/src/main/java/org/apache/hadoop/hive/shims/Hadoop23Shims.java: ########## @@ -1334,10 +1331,19 @@ public static class HdfsEncryptionShim implements HadoopShims.HdfsEncryptionShim private final Configuration conf; - public HdfsEncryptionShim(URI uri, Configuration conf) throws IOException { + public static HdfsEncryptionShim createInstance(URI uri, Configuration conf) throws IOException { + HdfsAdmin hadmin; + KeyProvider keyP; + hadmin = new HdfsAdmin(uri, conf); + keyP = hadmin.getKeyProvider(); Review Comment: ```suggestion HdfsAdmin hadmin = new HdfsAdmin(uri, conf); KeyProvider keyP = hadmin.getKeyProvider(); ``` Thanks for the update! In this case, we may not have to separate assignments from declarations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
