okumin commented on code in PR #5777:
URL: https://github.com/apache/hive/pull/5777#discussion_r2053393943
##########
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDTFGetSQLSchema.java:
##########
@@ -87,9 +87,6 @@ public void testWithSimpleTypes() throws Exception {
@Test
public void testWithDDL() throws Exception {
- // Set the execution engine to mr to avoid the NPE exception in stats flow
- // TODO: HIVE-28618: TestGenericUDTFGetSQLSchema to run on Tez
- conf.set("hive.execution.engine", "mr");
Review Comment:
This is a part of [the decommission of Hive on
MapReduce](https://issues.apache.org/jira/browse/HIVE-28027). In my
understanding, we've been migrating exceptional test cases that were excluded
[here](https://github.com/apache/hive/pull/4973/files) only to Tez, which means
`testWithSimpleTypes` in this file is already not tested with MR. It is also
not an unfair proposal to keep MR test cases as long as MR is not removed! In
my personal opinion, we don't have CI power to test every feature on the
deprecated MapReduce.
@abstractdog Do you have a suggestion about the work under the umbrella?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
