ngsg commented on PR #5771:
URL: https://github.com/apache/hive/pull/5771#issuecomment-2821213895
@okumin , @deniskuzZ , @zratkai, thank you for your review. I've updated the
branch to address your feedback and improve code quality. The main changes are
summarized as follows:
- Renamed the new classes
- Integrated the temporary table layer and session feature layer
- Updated {Session/LocalCaching}MetaStoreClientProxy to handle
ValidTxnWriteIdList properly
- Modified SessionMetaStoreClientProxy to set processorCapability in
advance, ensuring the cached key matches the actual request
- Changed the access level of TempTable from package-private to public, in
order to place all proxy classes under the same directory
There are still several remaining issues, including `SG:FIXME` markers and
some unchecked areas. In the latest commit, I focused on
`SessionMetaStoreClientProxy` and plan to move on to the other proxy classes.
I’d appreciate it if you could review the changes and share any considerations
I may have missed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
