deniskuzZ commented on code in PR #5780:
URL: https://github.com/apache/hive/pull/5780#discussion_r2054381088
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java:
##########
@@ -3252,7 +3252,7 @@ public Partition getPartitionWithAuth(String catName,
String dbName, String tblN
openTransaction();
MPartition mpart = getMPartition(catName, dbName, tblName, partVals,
null);
if (mpart == null) {
- commitTransaction();
+ success = commitTransaction();
Review Comment:
why not just move `commitTransaction()` to finally and remove the flag
completely? this is a simple select, there is nothing to rollback
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
