wecharyu commented on code in PR #5745:
URL: https://github.com/apache/hive/pull/5745#discussion_r2054533456
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java:
##########
@@ -869,6 +869,9 @@ boolean getPartitionsByExpr(String catName, String dbName,
String tblName,
List<Partition> result, GetPartitionsArgs args)
throws TException;
+ String getExprStringByExpr(String catName, String dbName, String tblName,
Review Comment:
`RawStore` API is usually used to handle the metadata read/write through
backend RDBS, I think it's not good to add this new API.
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/PartFilterExprUtil.java:
##########
@@ -35,7 +35,7 @@ public class PartFilterExprUtil {
private static final Logger LOG =
LoggerFactory.getLogger(PartFilterExprUtil.class.getName());
- public static ExpressionTree makeExpressionTree(PartitionExpressionProxy
expressionProxy,
+ public static String getExpressionString(PartitionExpressionProxy
expressionProxy,
Review Comment:
It's better to create a new method named `getExpressionString()` instead of
changing the existing method `makeExpressionTree()`, so we do not need change
the calls of `makeExpressionTree()` everywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
