ramitg254 commented on code in PR #5715: URL: https://github.com/apache/hive/pull/5715#discussion_r2060204342
########## ql/src/java/org/apache/hadoop/hive/ql/ddl/table/column/drop/AlterTableDropColumnOperation.java: ########## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hive.ql.ddl.table.column.drop; + +import com.google.common.collect.ImmutableSet; +import org.apache.hadoop.hive.metastore.api.FieldSchema; +import org.apache.hadoop.hive.metastore.api.StorageDescriptor; +import org.apache.hadoop.hive.ql.ErrorMsg; +import org.apache.hadoop.hive.ql.ddl.DDLOperationContext; +import org.apache.hadoop.hive.ql.ddl.table.AbstractAlterTableOperation; +import org.apache.hadoop.hive.ql.ddl.table.AlterTableUtils; +import org.apache.hadoop.hive.ql.io.orc.OrcSerde; +import org.apache.hadoop.hive.ql.io.parquet.serde.ParquetHiveSerDe; +import org.apache.hadoop.hive.ql.metadata.HiveException; +import org.apache.hadoop.hive.ql.metadata.Partition; +import org.apache.hadoop.hive.ql.metadata.Table; +import org.apache.hadoop.hive.serde2.MetadataTypedColumnsetSerDe; +import org.apache.hadoop.hive.serde2.avro.AvroSerdeUtils; +import org.apache.hadoop.hive.serde2.columnar.ColumnarSerDe; +import org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe; + +import java.util.ArrayList; +import java.util.List; +import java.util.Set; + +/** + * Operation process of dropping column. + */ +public class AlterTableDropColumnOperation extends AbstractAlterTableOperation<AlterTableDropColumnDesc> { + + public AlterTableDropColumnOperation(DDLOperationContext context, AlterTableDropColumnDesc desc) { + super(context, desc); + } + + @Override + protected void doAlteration(Table table, Partition partition) throws HiveException { + StorageDescriptor sd = getStorageDescriptor(table, partition); + String serializationLib = sd.getSerdeInfo().getSerializationLib(); + AvroSerdeUtils.handleAlterTableForAvro(context.getConf(), serializationLib, table.getTTable().getParameters()); + + if ("org.apache.hadoop.hive.serde.thrift.columnsetSerDe".equals(serializationLib)) { Review Comment: since `VALID_SERIALIZATION_LIBS` in `AlterTableReplaceColumnsOperation.java` is used to check but since most of the serde mentioned in that set require some changes which i already added from replace columns to drop column so i thought there is not a specific need to check as if a particular serde is present in `VALID_SERIALIZATION_LIBS` because it will automatically throw an error if it could not be able to do that operation as there is also not that kind of specific set like `VALID_SERIALIZATION_LIBS` is used in `AlterTableAddColumnsOperation.java` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
