deniskuzZ commented on code in PR #5715:
URL: https://github.com/apache/hive/pull/5715#discussion_r2063611458
##########
ql/src/test/results/clientnegative/orc_drop_column_acid.q.out:
##########
@@ -0,0 +1,13 @@
+PREHOOK: query: create table src_orc (key tinyint, val string) clustered by
(val) into 2 buckets stored as orc TBLPROPERTIES ('transactional'='true')
+PREHOOK: type: CREATETABLE
+PREHOOK: Output: database:default
+PREHOOK: Output: default@src_orc
+POSTHOOK: query: create table src_orc (key tinyint, val string) clustered by
(val) into 2 buckets stored as orc TBLPROPERTIES ('transactional'='true')
+POSTHOOK: type: CREATETABLE
+POSTHOOK: Output: database:default
+POSTHOOK: Output: default@src_orc
+PREHOOK: query: alter table src_orc drop column val
+PREHOOK: type: ALTERTABLE_DROPCOL
+PREHOOK: Input: default@src_orc
+PREHOOK: Output: default@src_orc
+FAILED: Execution Error, return code 10259 from
org.apache.hadoop.hive.ql.ddl.DDLTask. Drop column is not supported for table
default.src_orc. SerDe may be incompatible.
Review Comment:
ok, but since ACID does not support it, why are we adding ACID specific
checks?
````
if (AcidUtils.isTransactionalTable(table)) {
setAcidDdlDesc(desc);
}
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
