lirui-apache commented on code in PR #5204:
URL: https://github.com/apache/hive/pull/5204#discussion_r2065658158
##########
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java:
##########
@@ -1964,4 +1964,13 @@ public List<SQLPrimaryKey> getPrimaryKeys(String
db_name, String tbl_name) throw
}
return ret;
}
+
+ long updateTableParam(Table table, String key, String expectedValue, String
newValue) {
+ String queryText = String.format("UPDATE \"TABLE_PARAMS\" SET
\"PARAM_VALUE\" = ? " +
+ "WHERE \"PARAM_KEY\" = ? AND \"PARAM_VALUE\" = ? AND \"TBL_ID\" IN
" +
Review Comment:
Thanks @pan3793 for reporting the issue. I agree it's better to use scalar
subquery here. But since both 2.x and 3.x lines are EOL, and subquery is not
used in 4.0, so I guess we won't have to do anything at the moment, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
