deniskuzZ commented on code in PR #5621:
URL: https://github.com/apache/hive/pull/5621#discussion_r2063923012


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java:
##########
@@ -317,16 +317,22 @@ public List<String> findColumnsWithStats(CompactionInfo 
ci) throws MetaException
 
   @Override
   public void updateCompactorState(CompactionInfo ci, long compactionTxnId) 
throws MetaException {
+    boolean runInTxn = compactionTxnId > -1;

Review Comment:
   `> 0`
   `0` shouldn't be a valid txnId, have you checked when we pass 0, maybe test 
is wrong and needs to be updated?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to