difin commented on code in PR #5792:
URL: https://github.com/apache/hive/pull/5792#discussion_r2074494422
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergAcidUtil.java:
##########
@@ -206,10 +207,11 @@ public static int parseSpecId(Record rec) {
return rec.get(FILE_READ_META_COLS.get(MetadataColumns.SPEC_ID),
Integer.class);
}
- public static long computePartitionHash(Record rec) {
+ public static long computePartitionHash(Table table, Record rec) {
StructProjection part =
rec.get(FILE_READ_META_COLS.get(PARTITION_STRUCT_META_COL),
StructProjection.class);
+ Types.StructType partitionType = Partitioning.partitionType(table);
// we need to compute a hash value for the partition struct so that it can
be used as a sorting key
- return computeHash(part);
+ return computeHash(partitionType).hash(part);
Review Comment:
Updated problem statement and the fix to not rely on partition hash for
unique identification of partitions in compaction query.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
