kasakrisz commented on code in PR #5798:
URL: https://github.com/apache/hive/pull/5798#discussion_r2081480509
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java:
##########
@@ -1364,4 +1365,16 @@ public SourceTable createSourceTable() {
sourceTable.setDeletedCount(0L);
return sourceTable;
}
+
+ public boolean isDruidTable() {
+ return isNonNative() &&
getStorageHandler().toString().equals(Constants.DRUID_HIVE_STORAGE_HANDLER_ID);
+ }
+
+ public boolean isJdbcTable() {
+ return isNonNative() &&
getStorageHandler().toString().equals(Constants.JDBC_HIVE_STORAGE_HANDLER_ID);
+ }
Review Comment:
Let's just focus on collecting the virtual columns. I like the new method
`getVirtualColumns`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
