deniskuzZ commented on code in PR #5591:
URL: https://github.com/apache/hive/pull/5591#discussion_r2082260133
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/add/AbstractAddPartitionAnalyzer.java:
##########
@@ -70,7 +70,7 @@ protected void analyzeCommand(TableName tableName,
Map<String, String> partition
}
AlterTableAddPartitionDesc desc = new
AlterTableAddPartitionDesc(table.getDbName(), table.getTableName(),
- ifNotExists, partitions);
+ ifNotExists, partitions,
conf.get("hcat.dynamic.partitioning.custom.pattern", null));
Review Comment:
why do you need to specify `null` default and not use HiveConf constant?
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/add/AbstractAddPartitionAnalyzer.java:
##########
@@ -70,7 +70,7 @@ protected void analyzeCommand(TableName tableName,
Map<String, String> partition
}
AlterTableAddPartitionDesc desc = new
AlterTableAddPartitionDesc(table.getDbName(), table.getTableName(),
- ifNotExists, partitions);
+ ifNotExists, partitions,
conf.get("hcat.dynamic.partitioning.custom.pattern", null));
Review Comment:
why do you need to specify `null` default and not use HiveConf var?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
