armitage420 commented on code in PR #5779:
URL: https://github.com/apache/hive/pull/5779#discussion_r2083500252
##########
common/src/java/org/apache/hadoop/hive/common/type/Timestamp.java:
##########
@@ -162,6 +162,11 @@ public long toEpochMilli() {
return localDateTime.toInstant(ZoneOffset.UTC).toEpochMilli();
}
+ public long toEpochMicro() {
+ return localDateTime.toEpochSecond(ZoneOffset.UTC) * 1_000_000
Review Comment:
Doing so might lead to loss of precision due to integer overflow. Hence we
are parsing the value to seconds here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
