amansinha100 commented on code in PR #5798:
URL: https://github.com/apache/hive/pull/5798#discussion_r2083845426
##########
hbase-handler/src/test/results/positive/hbase_queries.q.out:
##########
@@ -151,14 +151,14 @@ STAGE PLANS:
predicate: UDFToDouble(key) is not null (type: boolean)
Statistics: Num rows: 1 Data size: 4 Basic stats: COMPLETE
Column stats: NONE
Select Operator
- expressions: key (type: int)
+ expressions: UDFToDouble(key) (type: double)
Review Comment:
The new plan with the pushed down cast 'key' to double on both sides of the
join looks good to me, although I don't know why the extraneous virtual columns
in the past would have prevented the push down since the cast is on a user
column. But that's a separate topic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]