okumin commented on PR #5812:
URL: https://github.com/apache/hive/pull/5812#issuecomment-2876455478

   I assume the class is really not needed.
   
   I'd like to remove the name also from the comment in HiveMetaStore.java.
   
   ```sh
   % git grep HiveMetaStoreClientPreCatalog
   
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java:
   * This method is called indirectly by HiveMetastoreClient and 
HiveMetaStoreClientPreCatalog
   
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java:
   * change in HiveMetastoreClient and HiveMetaStoreClientPreCatalog.
   
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java:public
 class HiveMetaStoreClientPreCatalog implements IMetaStoreClient, AutoCloseable 
{
   
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java:
  static final protected Logger LOG = 
LoggerFactory.getLogger(HiveMetaStoreClientPreCatalog.class);
   
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java:
  public HiveMetaStoreClientPreCatalog(Configuration conf) throws MetaException 
{
   
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java:
  public HiveMetaStoreClientPreCatalog(Configuration conf, HiveMetaHookLoader 
hookLoader) throws MetaException {
   
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java:
  public HiveMetaStoreClientPreCatalog(Configuration conf, HiveMetaHookLoader 
hookLoader, Boolean allowEmbedded)
   
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java:
      HiveMetaStoreClientPreCatalog.class.getClassLoader(),
   
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestCatalogNonDefaultSvr.java:
    return new HiveMetaStoreClientPreCatalog(conf);
   
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestCatalogOldClient.java:
    return new HiveMetaStoreClientPreCatalog(conf);
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to