deniskuzZ commented on code in PR #5804:
URL: https://github.com/apache/hive/pull/5804#discussion_r2087230529
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MColumnDescriptor.java:
##########
@@ -29,23 +30,33 @@
* A wrapper around a list of columns.
*/
public class MColumnDescriptor {
- private List<MFieldSchema> cols;
+ private List<MColumn> columns;
+ private long id;
public MColumnDescriptor() {}
- /**
- *
- * @param cols
- */
public MColumnDescriptor(List<MFieldSchema> cols) {
- this.cols = cols;
+ columns = new ArrayList<>(cols.size());
+ for (MFieldSchema schema : cols) {
+ columns.add(new MColumn(schema.getName(), schema.getType(),
schema.getComment()));
+ }
+ }
+
+ public List<MColumn> getColumns() {
+ return columns;
}
public List<MFieldSchema> getCols() {
- return cols;
+ List<MFieldSchema> schemas = new ArrayList<>();
+ if (getColumns() != null) {
Review Comment:
@dengzhhu653, but the `getCols()` is executed in the loop in application
code leading to unnecessary repetitive fields transform to List<MFieldSchema>.
example
````
for (MColumnDescriptor cd : cdIdToColumnDescriptor.values()) {
rowCount += cd.getCols().size();
}
````
also `sd.getCD().getCols() == null` now would always be false
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
