zhangbutao commented on PR #5444: URL: https://github.com/apache/hive/pull/5444#issuecomment-2893131327
> @vrozov, noted. @zhangbutao, anything pending here? Can we merge? > LGTM, however, we should test the backward compatibility To be honest, I really haven't found a good solution to address the changes in the qtests output results caused by the Sketch library code. Perhaps I'm a little too lazy to continue researching this issue anymore. :) About this PR, IMO, I think there shouldn't be any compatibility issues. The affected are some estimation functions(cume_dist & ds_kll_sketch & ntile ). These functions are only used by users in SQL execution, and the results of these estimation functions will not be stored in HMS. So, at least from the HMS perspective, there won't be any compatibility issues. However, the user might need to modify the SQL execution result if they . But I think such incompatibility changes can be accepted by users because they need to understand that this function is an estimated calculation and the error variation is reasonable. BTW, If we want to inform users that the results of using this estimation function may vary**, we might need to add a documentation note in the next release version to remind users that the results of using these functions may change in the new version.** At last, In the long run, we might need to port these function codes from the sketches library to the hive library so that hive can fully handle any changes to these functions. Well, saying all that might just be an excuse I made up to avoid continuing to study this issue. :) CC @okumin @asolimando -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
