difin commented on code in PR #5792:
URL: https://github.com/apache/hive/pull/5792#discussion_r2098209069
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergFilterFactory.java:
##########
@@ -228,6 +228,32 @@ private static Object convertLiteral(Object literal,
TransformSpec transform) {
}
}
+ public static Object convertPartitionLiteral(Object literal, TransformSpec
transform) {
Review Comment:
Because for the `DAY`, `TRUNCATE` and `BUCKET` transforms `convertLiteral()`
method makes wrong conversions which cause exceptions. I added a Java
integration test that tests all the transforms.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
