kokila-19 commented on code in PR #5803:
URL: https://github.com/apache/hive/pull/5803#discussion_r2102122342
##########
itests/util/src/main/java/org/apache/hadoop/hive/ql/QOutProcessor.java:
##########
@@ -44,13 +44,17 @@
public class QOutProcessor {
public static final String PATH_HDFS_REGEX =
"(hdfs://)([a-zA-Z0-9:/_\\-\\.=])+";
public static final String PATH_HDFS_WITH_DATE_USER_GROUP_REGEX =
- "([a-z]+) ([a-z]+)([ ]+)([0-9]+) ([0-9]{4}-[0-9]{2}-[0-9]{2}
[0-9]{2}:[0-9]{2}) "
+ "([a-z]+) ([a-z]+)([ ]+)((?!0\\s)[0-9]+) ([0-9]{4}-[0-9]{2}-[0-9]{2}
[0-9]{2}:[0-9]{2}) "
+ PATH_HDFS_REGEX;
+ public static final String PATH_HDFS_WITH_DATE_USER_GROUP_ZERO_SIZE_REGEX =
Review Comment:
Because of the way we add mask with patterns
```
add(toPatternPair(PATH_HDFS_WITH_DATE_USER_GROUP_REGEX, String.format("%s
%s$3%s %s $6%s",
HDFS_USER_MASK, HDFS_GROUP_MASK, HDFS_SIZE_MASK, HDFS_DATE_MASK,
HDFS_MASK)));
```
Here, we can't distinguish between 0 and non-zero values to decide whether
to use HDFS_SIZE_MASK or not. So , I had to add another regex to make it work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
