saihemanth-cloudera commented on code in PR #5804:
URL: https://github.com/apache/hive/pull/5804#discussion_r2102991208


##########
standalone-metastore/metastore-server/src/main/resources/package.jdo:
##########
@@ -384,10 +384,13 @@
       <field name="id" primary-key="true" value-strategy="native">
         <column name="CD_ID" jdbc-type="BIGINT" />
       </field>
-      <field name="columns" mapped-by="cd">
+      <field name="fields" mapped-by="cd">
         <order column="INTEGER_IDX"/>
         <collection element-type="MColumn" dependent-element="true" />
       </field>
+      <field name="columns" persistence-modifier="none">

Review Comment:
   All the fields declared in JDO are persistent by default. i.e.., Data 
Nucleus assumes that there is mapping of this field to a column in back end db 
(here it assumes that there is 1-1 mapping of columns field to a column in CDS 
table). It explicitly say that this field is only used in application layer and 
that there is no such column in the DB, we need to declare it as 
persistence-modifier="none".
   `@NotPersistant` annotation mentioned in Java is not taking into effect 
unless we mention it in `.jdo` class. So I left the annotation for future 
reference to the developers.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to