deniskuzZ commented on code in PR #5628:
URL: https://github.com/apache/hive/pull/5628#discussion_r2111937642
##########
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/HMSTablePropertyHelper.java:
##########
@@ -131,6 +151,103 @@ public static void updateHmsTableForIcebergTable(
tbl.setParameters(parameters);
}
+ /**
+ * Create {@link PartitionSpec} based on the partition information stored in
+ * {@link TransformSpec}.
+ * @param configuration a Hadoop configuration
+ * @param schema iceberg table schema
+ * @return iceberg partition spec, always non-null
+ */
+ public static PartitionSpec createPartitionSpec(Configuration configuration,
Schema schema) {
Review Comment:
I think It should remain in `IcebergTableUtil`. How is that related to table
properties?
````
- IcebergTableUtil.spec(configuration, schema);
+ HMSTablePropertyHelper.createPartitionSpec(configuration, schema);
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
