zabetak commented on code in PR #5829: URL: https://github.com/apache/hive/pull/5829#discussion_r2113440334
########## standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestObjectStoreSecondaryPoolLeak.java: ########## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the Review Comment: There is nothing specific to `jdbc-faulty` that distinguishes it from other similar dependencies. For instance, HikariCP is maintained principally by one person, datanucleus as well, and possibly many others from those that are listed in the project. I can understand that there is a burden when new dependencies come to the project but in the end it is a question of pros & cons. If you believe that the test does not add enough value then I am fine to remove it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
