deniskuzZ commented on PR #5834: URL: https://github.com/apache/hive/pull/5834#issuecomment-2929295475
hi @dengzhhu653, need your input here. `hive-metastore` and `hive-standalone-metastore-rest-catalog` artifacts are not packaged in metastore-server tar.gz. I do not fully understand the purpose of `hive-metastore` and why it wasn't moved inside the standalone metastore. Nevertheless, it's imported in `hive-standalone-metastore-server` as a test dependency, by changing it to compile we could include it in tar.gz. A bigger problem is with `hive-standalone-metastore-rest-catalog`. It has a dependency on `hive-standalone-metastore-server`, that in my opinion, is a bad design decision. In order to package all required classes in tar.gz we have a few options: 1. remove `hive-standalone-metastore-rest-catalog` dependency on `hive-standalone-metastore-server` so we could include rest-catalog in metastore-server. 2. define a `packaging` module similar to Hive. I think option 1 would support a better module structure and avoid potential circular dependencies. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
