dengzhhu653 commented on code in PR #5843:
URL: https://github.com/apache/hive/pull/5843#discussion_r2128193734
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/tools/metatool/MetaToolTaskMetadataSummary.java:
##########
@@ -183,25 +185,45 @@ Pair<MetaSummarySchema, List<MetadataTableSummary>>
obtainAndFilterSummary() thr
MetaSummarySchema extraSchema = new MetaSummarySchema();
for (Class<? extends MetaSummaryHandler> handler :
nonNativeSummaries.keys()) {
Configuration conf = getObjectStore().getConf();
+ List<Future<?>> futures = new ArrayList<>();
try (MetaSummaryHandler summaryHandler =
JavaUtils.newInstance(handler)) {
summaryHandler.setConf(conf);
summaryHandler.initialize(MetaStoreUtils.getDefaultCatalog(conf),
formatJson, extraSchema);
List<MetadataTableSummary> tableSummaries =
nonNativeSummaries.get(handler);
// Filter those we don't want to collect
Set<Long> tableIds =
getObjectStore().filterTablesForSummary(tableSummaries, recentUpdatedDays,
maxNonNativeTables);
+ if (service == null) {
+ int nThreads = Math.min(MetastoreConf.getIntVar(conf,
MetastoreConf.ConfVars.METADATA_SUMMARY_NONNATIVE_THREADS),
+ tableIds.size());
+ if (nThreads > 1) {
+ service = Executors.newFixedThreadPool(nThreads,
+ new
ThreadFactoryBuilder().setDaemon(true).setNameFormat("MetaToolTaskMetadataSummary
#%d").build());
+ }
+ }
for (MetadataTableSummary summary : tableSummaries) {
- if (tableIds.contains(summary.getTableId())) {
+ if (!tableIds.contains(summary.getTableId())) {
+ filteredSummary.put(summary, null);
+ } else {
TableName tableName = new TableName(summary.getCatalogName(),
summary.getDbName(), summary.getTblName());
- summaryHandler.appendSummary(tableName, summary);
- } else {
- filteredSummary.put(summary, null);
- }
- // If there is an exception while collecting the summary, remove it
- if (summary.isDropped()) {
- filteredSummary.put(summary, null);
+ Runnable task = () -> {
+ summaryHandler.appendSummary(tableName, summary);
Review Comment:
My idea is to try the best to collect a `correct` summary, if we just ignore
the exception, this will give a wrong insight of the table, which could be
misleading.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
