okumin commented on code in PR #5837: URL: https://github.com/apache/hive/pull/5837#discussion_r2128385898
########## ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/VectorUDFDayOfWeekString.java: ########## @@ -20,25 +20,17 @@ import java.nio.charset.CharacterCodingException; import java.text.ParseException; -import java.text.SimpleDateFormat; -import java.util.Calendar; -import java.util.Date; -import java.util.TimeZone; import org.apache.hadoop.io.Text; +import org.apache.hadoop.hive.common.type.Date; +import org.apache.hive.common.util.DateParser; /** * Expression to get day of week. * Extends {@link VectorUDFTimestampFieldString} */ public final class VectorUDFDayOfWeekString extends VectorUDFTimestampFieldString { - private static final long serialVersionUID = 1L; Review Comment: Thanks. I will merge this after the 24-hour rule is satisfied. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org