deniskuzZ commented on code in PR #5847:
URL: https://github.com/apache/hive/pull/5847#discussion_r2132409095
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java:
##########
@@ -739,9 +739,10 @@ public enum ConfVars {
DATANUCLEUS_INIT_COL_INFO("datanucleus.rdbms.initializeColumnInfo",
"datanucleus.rdbms.initializeColumnInfo", "NONE",
"initializeColumnInfo setting for DataNucleus; set to NONE at least on
Postgres."),
-
DATANUCLEUS_PLUGIN_REGISTRY_BUNDLE_CHECK("datanucleus.plugin.pluginRegistryBundleCheck",
- "datanucleus.plugin.pluginRegistryBundleCheck", "LOG",
- "Defines what happens when plugin bundles are found and are duplicated
[EXCEPTION|LOG|NONE]"),
+
DATANUCLEUS_PLUGIN_REGISTRY_BUNDLE_CHECK("datanucleus.plugin.pluginRegistryBundleCheck".toLowerCase(),
Review Comment:
:) interesting style.
Hive already creates plenty of HiveConf obj instances that take a
significant part of Heap, so i am not sure it's a good idea to add an overhead
by creating unnecessary objects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
