deniskuzZ commented on code in PR #5849:
URL: https://github.com/apache/hive/pull/5849#discussion_r2133887868
##########
ql/src/test/org/apache/hadoop/hive/ql/metadata/TestMSCKRepairOnAcid.java:
##########
@@ -164,6 +166,19 @@ public void testAddPartitionHighWriteIdException() throws
Exception {
CommandProcessorException e = runStatementOnDriverNegative("msck repair
table " + acidTblPartMsck);
Assert.assertEquals(-1, e.getErrorCode());
+ String tableName = acidTblPartMsck.toLowerCase(); // Match Hive's internal
table naming
+ long maxWriteIdOnFilesystem = 2L; // From source table insertions (2
operations)
+ long maxAllocatedWriteId = 1L; // From target table insertion (1 operation)
+
+ String expectedMessage = MessageFormat.format(
Review Comment:
Please don't use the `MessageFormat` in the expectation, just hardcode and
update the text
````
String expectedMessage = "The highest writeId [2] in the table
'acidtblpartmsck' is greater than the maximum writeId allocated in the
metastore [1]"
Assert.assertTrue(e.getCause() instanceof MetaException);
Assert.assertEquals(expectedMessage, e.getCause().getMessage());
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
