abstractdog commented on PR #5589: URL: https://github.com/apache/hive/pull/5589#issuecomment-2956773378
LGTM I like the idea that the generated protobuf classes now reside in the target folder instead of being included as a generated source while building (as both ways lead to the same result) we can merge this if: 1. there is a green precommit 2. @Aggarwal-Raghav : you can check that classes generated from protobuf classes are present in the target/classes and the result jar -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
