abstractdog commented on code in PR #5834: URL: https://github.com/apache/hive/pull/5834#discussion_r2140007685
########## standalone-metastore/metastore-server/src/docker/Dockerfile: ########## @@ -0,0 +1,85 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +ARG BUILD_ENV + +FROM ubuntu as unarchive +ONBUILD COPY hadoop-*.tar.gz /opt +ONBUILD COPY apache-hive-standalone-metastore-server-*-bin.tar.gz /opt + +FROM ubuntu as archive +ARG HADOOP_VERSION +ARG HIVE_VERSION +ONBUILD RUN apt-get update && apt-get -y install wget +ONBUILD RUN wget https://archive.apache.org/dist/hadoop/core/hadoop-$HADOOP_VERSION/hadoop-$HADOOP_VERSION.tar.gz && \ + wget https://archive.apache.org/dist/hive/hive-standalone-metastore-$HIVE_VERSION/apache-hive-standalone-metastore-server-$HIVE_VERSION-bin.tar.gz +ONBUILD RUN mv hadoop-$HADOOP_VERSION.tar.gz /opt && \ + mv apache-hive-standalone-metastore-server-$HIVE_VERSION-bin.tar.gz /opt + +FROM ubuntu as buildarchive +ARG HADOOP_VERSION +ARG HIVE_VERSION +ONBUILD RUN apt-get update && apt-get -y install wget +ONBUILD RUN wget https://archive.apache.org/dist/hadoop/core/hadoop-$HADOOP_VERSION/hadoop-$HADOOP_VERSION.tar.gz +ONBUILD COPY ./apache-hive-standalone-metastore-server-$HIVE_VERSION-bin.tar.gz /opt +ONBUILD RUN mv hadoop-$HADOOP_VERSION.tar.gz /opt + +FROM ${BUILD_ENV} as env +RUN echo ${BUILD_ENV} +ARG HADOOP_VERSION +ARG HIVE_VERSION + +RUN tar -xzvf /opt/hadoop-$HADOOP_VERSION.tar.gz -C /opt/ && \ + rm -rf /opt/hadoop-$HADOOP_VERSION/share/doc/* && \ + tar -xzvf /opt/apache-hive-standalone-metastore-server-$HIVE_VERSION-bin.tar.gz -C /opt/ + +FROM eclipse-temurin:17.0.12_7-jre-ubi9-minimal AS run + +ARG HADOOP_VERSION +ARG HIVE_VERSION +COPY --from=env /opt/hadoop-$HADOOP_VERSION /opt/hadoop +COPY --from=env /opt/apache-hive-metastore-$HIVE_VERSION-bin /opt/hive + +# Install dependencies +RUN set -ex; \ + microdnf update -y; \ + microdnf -y install procps; \ + rm -rf /var/lib/apt/lists/* + +# Set necessary environment variables. +ENV HADOOP_HOME=/opt/hadoop \ Review Comment: nitpicking, but as you already use multiple environment variables, I prefer one ENV per line instead of the backslash magic, like: ``` ENV HADOOP_HOME=/opt/hadoop ENV HIVE_HOME=/opt/hive ENV HIVE_VER=$HIVE_VERSION ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
