deniskuzZ commented on code in PR #5628:
URL: https://github.com/apache/hive/pull/5628#discussion_r2142803168
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java:
##########
@@ -566,15 +600,15 @@ default void dropTable(String catName, String dbName,
String tableName)
* @throws TException Thrift transport exception
*/
@Deprecated
- void truncateTable(String dbName, String tableName, List<String> partNames)
throws MetaException, TException;
+ default void truncateTable(String dbName, String tableName, List<String>
partNames) throws MetaException, TException{}
- void truncateTable(TableName table, List<String> partNames) throws
TException;
+ default void truncateTable(TableName table, List<String> partNames) throws
TException{}
- void truncateTable(String dbName, String tableName, List<String> partNames,
- String validWriteIds, long writeId) throws TException;
+ default void truncateTable(String dbName, String tableName, List<String>
partNames,
+ String validWriteIds, long writeId) throws TException{}
- void truncateTable(String dbName, String tableName, List<String> partNames,
- String validWriteIds, long writeId, boolean deleteData) throws
TException;
+ default void truncateTable(String dbName, String tableName, List<String>
partNames,
Review Comment:
fix the spacing
should throw UnsupportedOperationException
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java:
##########
@@ -588,8 +622,8 @@ void truncateTable(String dbName, String tableName,
List<String> partNames,
* @throws TException Thrift transport exception
*/
@Deprecated
- void truncateTable(String catName, String dbName, String tableName,
List<String> partNames)
- throws MetaException, TException;
+ default void truncateTable(String catName, String dbName, String tableName,
List<String> partNames)
Review Comment:
drop the API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
