deniskuzZ commented on code in PR #5628: URL: https://github.com/apache/hive/pull/5628#discussion_r2144938273
########## standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java: ########## @@ -95,8 +105,9 @@ public interface IMetaStoreClient extends AutoCloseable { * create the directory for the catalog. * @throws TException general thrift exception. */ - void createCatalog(Catalog catalog) - throws AlreadyExistsException, InvalidObjectException, MetaException, TException; + default void createCatalog(Catalog catalog) Review Comment: @dengzhhu653, @ngsg, @okumin, what do you think about marking some of the methods as default and throwing `UnsupportedOperationException` in the IMetaStoreClient interface? This way, implementers wouldn't need to define unnecessary dummies. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org