Paramvir109 commented on code in PR #5845: URL: https://github.com/apache/hive/pull/5845#discussion_r2147018201
########## ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastHashTableLoader.java: ########## @@ -83,6 +88,10 @@ public VectorMapJoinFastHashTableLoader() { } + ExecutorService getLoadExecService() { Review Comment: I need this so I can actually shutdown the service in tearDown method after running unit test. Since loadExecService is a private member of the class, I thought to make a package-private getter for the same so that I can access it in unit test. Other approach will be to change access modifier of loadExecService to package-private -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org