okumin commented on code in PR #5887: URL: https://github.com/apache/hive/pull/5887#discussion_r2160332649
########## standalone-metastore/metastore-rest-catalog/src/main/java/org/apache/iceberg/rest/HMSCatalogFactory.java: ########## @@ -104,6 +83,11 @@ protected Catalog createCatalog() { if (configExtWarehouse != null) { properties.put("external-warehouse", configExtWarehouse); } + // For the testing purpose. HiveCatalog caches a metastore client in a static field. As our tests can spin up + // multiple HMS instances, we need a unique cache key. + final String servletIdKey = "metastore.iceberg.catalog.servlet.id"; + configuration.set(servletIdKey, UUID.randomUUID().toString()); Review Comment: Make sense. Although we may rename the parameter name or something, I tried to update it so. https://github.com/apache/hive/pull/5887/commits/ac80c8485b273f81deb075ec0b9bbe1b04f98359 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org