ngsg commented on code in PR #5771:
URL: https://github.com/apache/hive/pull/5771#discussion_r2174273250


##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java:
##########
@@ -1463,6 +1436,14 @@ boolean listPartitionsByExpr(String catName, String 
db_name, String tbl_name, by
                                String default_partition_name, int max_parts, 
List<Partition> result)
       throws TException;
 
+  /**
+   * Get list of partitions matching specified serialized expression
+   * @param req PartitionsByExprRequest object
+   * @return whether the resulting list contains partitions which may or may 
not match the expr
+   * @throws TException thrift transport error or error executing the filter.
+   */
+  boolean listPartitionsByExpr(PartitionsByExprRequest req, List<Partition> 
result) throws TException;

Review Comment:
   Yes, I added a new `listPartitionsByExpr` that takes 
`PartitionsByExprRequest` in order to propagate `validWriteIdList` from 
`SessionMetaStoreClientProxy` to underlying porxies.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to