okumin commented on code in PR #5897:
URL: https://github.com/apache/hive/pull/5897#discussion_r2173147825


##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java:
##########
@@ -128,6 +128,13 @@ public class MetastoreConf {
       keyToVars.put(var.varname, var);
       keyToVars.put(var.hiveName, var);
     }
+    Configuration.addDeprecations(new Configuration.DeprecationDelta[] {

Review Comment:
   I didn't know this feature. Looks so nice.
   
https://github.com/apache/hadoop/blob/6eae1589aeea9bd9c6885e405bd9be5ef6199df7/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java#L555-L572
   
   Personally, +1 with the current approach.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to